🤑 GitHub - PennEngineer/BlackjackSolitaire: Blackjack Solitaire game using Java

Most Liked Casino Bonuses in the last 7 days 🖐

Filter:

Active

Free bonus

Sort:

Newest

Popular

Misc your whole shuffle function can be replaced by Collections. The best answers are voted up and rise to the top. You can run your game in a BlackJackGame class, which should maintain the game loop which would call other classes to deal a hand, get input, check end condition and apply results, after which it deals the next hand. Viewed 44k times. Mainly because they both represent a blackjack player the dealer and the player. Here are a couple of tips to get your started. I want to implement insurance and splitting, so any advice to help prepare the code for eventually adding those features would be really helpful! Caridorc Caridorc Sign up or log in Sign up using Google. Podcast New tools for new times. All the rest should ideally happen elsewhere. This seems unnecessary and confusing. Why does your Dealer class have hand and aHand? Post as a guest Name. Probably not. There are more classes you could create, but this would be a good start. Will it make sense for rank , suit and value to change in the lifetime of a Card instance? With a Hand class, you would already separate out some of it. Look through all the comments in your code, if they are not needed, then remove them, if they are needed, then try to change the code in a way to not need comments. Linked 4. It contains the dealer AI when does the dealer hit? The main reason is that it separates those things from the rest. Sign up using Facebook. There is a setValue method, which you don't need either. They don't. The best code doesn't need comments. Home Questions Tags Users Unanswered. This practice can help you spot some design bugs. I just completed my first multi class program, Blackjack, and it works! What is your name? Phrancis: A final review of a good member. Why the developers who use Rust love it so much. Make everything final that doesn't need to change or doesn't make sense to ever change. In Eclipse the keyboard shortcut is Control-Shift-f. In fact most of the other comments in the code don't add value either. Active 1 year ago. It makes your code more readable, and especially more reusable.

Code Review Stack Exchange is a question and answer site for peer programmer code reviews. Question feed.

I would also remove all the prints they make code reuse difficult, and lead to bad code structure , and separate the AI logic to it's own class this would make it easier to change the rules, because they are all in one place. Takes into account the value of aces. Active Oldest Votes. Related 2. Excessive comments Do these comments add anything new that isn't clear already? Your Dealer class contains a lot of code that I would not place there. ArrayList; import java. Let's update the modal for new askers. So make these fields final. First attempt at a Java Blackjack game Ask Question. The same goes for public static boolean hasBlackJack int handValue and public static boolean isHitorStand String hitter and public static boolean checkBust int handvalue for the latter you should move printing out of the function. In this case, your Dealer and your Blackjack class contain a lot of duplication. Sign up using Email and Password. I suggest to reformat the entire thing, to make the code look more familiar and easier to read for the majority of Java coders. It would be better to put these in public static final variables with descriptive names, to clarify the purpose of these values, have them together near the top of the code for easier control and flexibility to play with. The code doesn't follow the common formatting generated by the auto-format option of common IDEs like Eclipse and IntelliJ. Review the other classes too. It only takes a minute to sign up. Your Blackjack class also does way too much. Aces are 11 for now. The Overflow Blog. Sign up to join this community. Making Card immutable Will it make sense for rank , suit and value to change in the lifetime of a Card instance? It is the player as well as the game, which violates the single responsibility principle. It can calculate and store the hand value. What posts should be escalated to staff using [status-review], and how do I…. There are too many magic numbers in the code. It seems mostly internally consistent that's the important part , but does not really match what most Java programmers are used to. Do you mind explaining a little bit more about that point? Asked 5 years ago. Jared Jared 1 1 gold badge 5 5 silver badges 17 17 bronze badges. Email Required, but never shown. A generic Player class might be helpful, from which Dealer and HumanPlayer extend. If you want to iterate over the possible suits, you can do for Suit suit : Suit. Finally, my main method is pretty long — I was wondering if this is typical of Java programs and, if not, how I can fix that. This would also avoid the duplication you currently have calcHandValue and Hit. If a jack, queen, or king the value is ten. Hot Network Questions. We're switching to CommonMark. Aces are taken into account. Featured on Meta. It allows the user to play Blackjack against a single dealer, with no other players at the table.